Skip to content

Conversation

emilykl
Copy link
Contributor

@emilykl emilykl commented Sep 26, 2025

No description provided.

@emilykl emilykl requested a review from camdecoster September 26, 2025 22:51
Copy link
Contributor

@camdecoster camdecoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all fine, but do we need to include the 'Tidy up...' PRs in the draftlogs?

@emilykl
Copy link
Contributor Author

emilykl commented Sep 26, 2025

Not necessarily, I don't feel that strongly about it, but as a consumer of other libraries I usually appreciate more detail in the changelog rather than less (makes it easier to point to a reference and say "this has been fixed since THIS version"). I think I'm starting to feel that any PR which introduces a change in the bundle should have a draftlog.

But, if you're strongly opposed I don't mind taking them out.

@camdecoster
Copy link
Contributor

I don't feel that strongly about this, but I'd argue that if someone wanted to know the changes between versions, they could look at the commit list. But it won't really hurt to have a bit more detail. And commit lists can be quite noisy.

@emilykl emilykl force-pushed the add-missing-draftlogs-2025-09 branch from cfc70e1 to 5d7f480 Compare September 26, 2025 23:10
@emilykl
Copy link
Contributor Author

emilykl commented Sep 26, 2025

@camdecoster I condensed the two 'tidy up...' PRs into a single draftlog, let me know if that works for you

@camdecoster
Copy link
Contributor

That's fine.

@emilykl emilykl merged commit fc5993d into master Sep 26, 2025
6 checks passed
@emilykl emilykl deleted the add-missing-draftlogs-2025-09 branch September 26, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants